Generate .d.ts files even if syntax or semantic errors are found#269
Merged
Conversation
🦋 Changeset detectedLatest commit: 4cdb04e The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
601f090 to
4cdb04e
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #178
The ts-plugin was generating type definitions for files containing errors, while codegen was not generating .d.ts files for files with errors. This created a discrepancy in the types recognized by both the tsserver and eslint Language Servers. While this issue is currently mostly unnoticed by most users, it will become more apparent once watch mode is implemented.
Therefore, we'll modify codegen to generate .d.ts files for files containing errors as well.
Incidentally,
tscexhibits similar behavior.