perf(whisper): reuse encoded audio features for word timestamps - #1432
Open
unohee wants to merge 1 commit into
Open
perf(whisper): reuse encoded audio features for word timestamps#1432unohee wants to merge 1 commit into
unohee wants to merge 1 commit into
Conversation
unohee
marked this pull request as ready for review
July 26, 2026 23:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DecodingResult.audio_featuresduring word-timestamp alignmentWhy
transcribe()already computes and retains encoded audio features in eachDecodingResult.find_alignment()discarded those features and calledmodel.encoder(mel)again before the cross-attention/DTW pass. Passing the existing features removes that duplicate encoder invocation without changing decoding or alignment math.M1 Max benchmark
Model:
mlx-community/whisper-large-v3-turbo, FP16, Korean meeting audio,word_timestamps=True,condition_on_previous_text=False.Parity evidence
On the deterministic 4-minute run, all of the following matched exactly:
The long-form default temperature tuple can sample stochastically after a fallback. Re-running an observed fallback region with the same
mx.random.seed()produced exact segment, token, timestamp, and probability parity across 19 segments and 53 words.Scope
This PR intentionally does not include the separate batched-decoding experiment. Fixed-window batching changed long-form window boundaries and failed the output-parity gate.