Repository navigation
Speed up CSD and PSD computations - #14355
Merged
Merged
Conversation
drammock
approved these changes
Sep 29, 2026
Member
|
are there particular tutorials you want to inspect before merging @larsoner? |
Member
Author
|
Mostly wanted to check that at least some examples got a little faster and they did (modestly faster on left / PR compared to right / main): 
|
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Oct 1, 2026
* upstream/main: (26 commits) Splitting _brain.py into multiple modules (phase 1) (mne-tools#14359) Fix small corner-case bug with moments (mne-tools#14364) Coregistration GUI modernisation (phase 5) (mne-tools#14353) FIX: Prevent memory leak in RawArray by removing data from _init_kwargs (mne-tools#14360) MAINT: Update code credit (mne-tools#14365) type-hint the rest of mne/_fiff (mne-tools#14352) MAINT: Update dependency specifiers (mne-tools#14362) MAINT: Update dependency specifiers (mne-tools#14357) Switch to mne-tools SPEC-0 action (mne-tools#14356) MAINT: Move Pixi file updates to autofix workflow (mne-tools#14345) BUG: Fix SNIRF landmark length unit scaling (mne-tools#14354) DRY dipole code and comment on implementation (mne-tools#14350) Speed up CSD and PSD computations (mne-tools#14355) [dependabot]: Bump the actions group with 4 updates (mne-tools#14349) MAINT: Update pre-commit hook versions (mne-tools#14347) Switch to `mne-tools/rename-towncrier` action (mne-tools#14344) Fix for latest pyvista-js (mne-tools#14343) Avoid copies and support larger files in EEGLAB export (mne-tools#14338) Remove line breaks in sponsors check issue text (mne-tools#14337) Fix EEGLAB events after dropped epochs (mne-tools#14067) ... # Conflicts: # mne/viz/_brain/_brain.py # mne/viz/backends/tests/test_renderer.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up spectral estimation (should help with mne-tools/mne-connectivity#486). Gives a ~4x speedup in
csd_array_multitaperand ~1.2-2x inpsd_array_multitaper. Managed to DRY the code a little bit at the same time, and peak memory usage went down a bit 🚀. Investigated and implemented with Claude Opus 5.5 and reviewed and iterated on by me. (I think it's probably not worth a changelog entry.) Pushing with circle full to make sure nothing breaks here but I think we can really trust our unit tests on this one.