Repository navigation
Fix blit and add selectable - #14368
Merged
Merged
Conversation
larsoner
requested review from
agramfort,
drammock and
mscheltienne
as code owners
October 1, 2026 16:25
drammock
approved these changes
Oct 5, 2026
Member
|
thx @larsoner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced by the new blitting code where if you had, say, 8 blitted axes, the figure would be
draw_idled 8 times. The fix is to use a single blitting manager monkey-patched onto the figure. Blitting is a figure-level operation, so it makes sense to share a single manager. Also adds aselectableoption to TFR plotting (was previously effectively hard-coded toTrue) to avoid some potential redraws when making static figures. Slowdown identified with the help of Claude Opus 5.5, which I then used to draft the changes, too (but I reviewed, understand, and iterated on them).