-
Notifications
You must be signed in to change notification settings - Fork 381
Strip alpha from inner skin parts #4373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think we decided to keep support for alpha within skin textures as there are mods which users can install that allow for the alpha to work in-game (even if it doesnt work in vanilla) - will leave the decision to @AlexTMjugador though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the Modrinth App, I think it makes the most sense to render skins as closely as possible to how the vanilla client does, which is a baseline most users will find reasonable. Since mods can change many aspects of skin rendering in countless ways, trying to account for those variations sounds both impractical and outside our scope.
When I first wrote this code, I chose not to implement transparency handling because the time required to fully understand Mojang's code and test the edge cases related to transparency didn't seem worth it, especially given that many third-party tools get it wrong anyway (so user expectations weren't clear to me, as @IMB11 noted, albeit for different reasons). However, the fact that someone submitted a PR to adjust the behavior to match the vanilla client is a strong signal that we should handle it that way 😄
|
A skin texture buffer is now converted to RGBA. This simplifies other code and allows "Notch transparent hack" to add transparency even if the original skin image is RGB or Grayscale. Also I've added 2 more skins to the |
AlexTMjugador
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you! ❤️
I think we can merge this after a few remaining nitpicks are addressed 🚀
Co-authored-by: Alejandro González <[email protected]> Signed-off-by: Jerozgen <[email protected]>
|
Done! |

Before:


After: