add option to run hoogle server over TLS#156
Merged
Merged
Conversation
| , repeat_ :: Int | ||
| , queryChunks :: [String] | ||
| , queryParsed :: Either ParseError Query | ||
| , queryText :: String |
Owner
There was a problem hiding this comment.
Generally I prefer my indentation style as it was originally. Not too fussed for pushing onto the Hoogle 4 branch, more a note for anything you submit to Hoogle 5.
Contributor
Author
There was a problem hiding this comment.
sure... Data and Convert below have the space so i thought i was keeping the style...
Owner
There was a problem hiding this comment.
Ah, fair enough, I guess you are being tripped up by my past inconsistencies - can't ask for more than keeping the style consistent, whatever it might be!
Owner
|
Looks good to me - the dependency on warp-tls looks very minor, since all its dependencies are already dependencies of Hoogle, so the total increase in dependencies is small. A patch to Hoogle 5 would be most welcome. |
ndmitchell
added a commit
that referenced
this pull request
Feb 23, 2016
add option to run hoogle server over TLS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hoogle server --https --cert="my_cert.pem" --key="my_key.pem"serves the hoogle pages over TLStested with a self-generated certificate:
