Skip to content

[stable8] fix(NcAppNavigationSettings): migrate to NcButton component#7700

Merged
mejo- merged 1 commit into
stable8from
fix/stable8/app_navigation_settings_ncbutton
Oct 21, 2025
Merged

[stable8] fix(NcAppNavigationSettings): migrate to NcButton component#7700
mejo- merged 1 commit into
stable8from
fix/stable8/app_navigation_settings_ncbutton

Conversation

@mejo-

@mejo- mejo- commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Manual partial backport of c7d40e9.

Replaces #7663

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • πŸ“˜ Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@mejo-
mejo- requested review from Antreesy, ShGKme and susnux October 21, 2025 14:31
@mejo- mejo- self-assigned this Oct 21, 2025
@mejo- mejo- added 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component labels Oct 21, 2025
@mejo- mejo- changed the title fix(NcAppNavigationSettings): migrate to NcButton component [stable8] fix(NcAppNavigationSettings): migrate to NcButton component Oct 21, 2025
Comment thread src/components/NcAppNavigationSettings/NcAppNavigationSettings.vue
Manual partial backport of c7d40e9.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo- force-pushed the fix/stable8/app_navigation_settings_ncbutton branch from e9f8cee to c077176 Compare October 21, 2025 14:41

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@mejo-
mejo- merged commit 68abbfc into stable8 Oct 21, 2025
17 of 19 checks passed
@mejo-
mejo- deleted the fix/stable8/app_navigation_settings_ncbutton branch October 21, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants