test(NcFilePicker): fix flaky tests#8619
Merged
odzhychko merged 1 commit intoJun 22, 2026
Merged
Conversation
Changed because of flakiness: - `picking a single file` - `picking multiple files` The rest were change for consistency. Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
odzhychko
force-pushed
the
flaky-NcFilePicker-tests
branch
from
June 8, 2026 18:15
b1fffc2 to
c60d7ba
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8619 +/- ##
=======================================
Coverage 54.05% 54.05%
=======================================
Files 106 106
Lines 3478 3478
Branches 1007 1008 +1
=======================================
Hits 1880 1880
Misses 1354 1354
Partials 244 244 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
odzhychko
enabled auto-merge
June 16, 2026 09:49
Contributor
|
@odzhychko please always add the appropriate labels and milestones. |
susnux
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Resolves flaky test that occurred locally for me and sometimes on CI. The issue was a race condition.
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicablestable8does not use PlaywrightInfo
Locally, you could observe failing test by running them repeatably: