Skip to content

fix(NcGuestContent): migrate style assignment fully to CSS#8677

Merged
Antreesy merged 1 commit into
mainfrom
fix/noid/guest-content-wrapper
Jun 30, 2026
Merged

fix(NcGuestContent): migrate style assignment fully to CSS#8677
Antreesy merged 1 commit into
mainfrom
fix/noid/guest-content-wrapper

Conversation

@Antreesy

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Suppress mentioned TypeError in production code
    • There is nothing relevant for end-user to see, and should be handled by developer
  • Assisted-by: ClaudeCode:claude-sonnet-4-6

🖼️ Screenshots

2026-06-25_10h37_33

🚧 Tasks

  • Check upstream pages that render it (maintenance / upgrade / pass protection)?
  • Are added styles required at all?

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@Antreesy Antreesy added this to the 9.8.3 milestone Jun 25, 2026
@Antreesy
Antreesy requested review from ShGKme and susnux June 25, 2026 09:00
@Antreesy Antreesy self-assigned this Jun 25, 2026
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: app-content Related to the app-content component labels Jun 25, 2026
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.06%. Comparing base (f54323d) to head (94fe6fe).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8677   +/-   ##
=======================================
  Coverage   54.06%   54.06%           
=======================================
  Files         106      106           
  Lines        3479     3479           
  Branches     1008     1008           
=======================================
  Hits         1881     1881           
  Misses       1354     1354           
  Partials      244      244           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme added the AI assisted This PR contains AI-assisted commits label Jun 25, 2026
Comment thread src/components/NcGuestContent/NcGuestContent.vue Outdated
@Antreesy
Antreesy force-pushed the fix/noid/guest-content-wrapper branch from 9ec294f to 6838a0a Compare June 25, 2026 11:30
@Antreesy Antreesy changed the title fix(NcGuestContent): warn instead of crash when #content element is missing fix(NcGuestContent): migrate style assignment fully to CSS Jun 25, 2026
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy force-pushed the fix/noid/guest-content-wrapper branch from 6838a0a to 94fe6fe Compare June 25, 2026 11:53
@Antreesy
Antreesy requested a review from ShGKme June 29, 2026 12:06

@mejo- mejo- left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look sensible to me.

@Antreesy

Copy link
Copy Markdown
Contributor Author

/backport to stable8

@Antreesy
Antreesy merged commit fef17a7 into main Jun 30, 2026
27 checks passed
@Antreesy
Antreesy deleted the fix/noid/guest-content-wrapper branch June 30, 2026 13:06
@susnux susnux modified the milestones: 9.8.3, 9.9.0 Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted This PR contains AI-assisted commits bug Something isn't working feature: app-content Related to the app-content component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants