Do not allow deletion from public albums#1749
Merged
artonge merged 1 commit intoApr 17, 2023
Merged
Conversation
artonge
enabled auto-merge
April 17, 2023 17:28
Collaborator
Author
|
/backport to stable25 |
Collaborator
Author
|
/backport to stable26 |
skjnldsv
approved these changes
Apr 17, 2023
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/feat/do_not_allow_deletion_from_public_albums
branch
from
April 17, 2023 19:48
0e4645c to
d1f532b
Compare
artonge
deleted the
artonge/feat/do_not_allow_deletion_from_public_albums
branch
April 17, 2023 19:56
|
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin/stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25 |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26 |
This was referenced Apr 18, 2023
|
but still there... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time didn't allow for a fully editable public album, so let's remove this half-baked feature for now.