Skip to content

enh: Add unique DOM identifiers for nav entries#2118

Merged
Pytal merged 1 commit into
masterfrom
enh/app-nav-data-id
Nov 15, 2023
Merged

enh: Add unique DOM identifiers for nav entries#2118
Pytal merged 1 commit into
masterfrom
enh/app-nav-data-id

Conversation

@Pytal

@Pytal Pytal commented Nov 10, 2023

Copy link
Copy Markdown
Member

Check DOM:

[...document.querySelectorAll('[data-id-app-nav-item]')].map(el => el.dataset.idAppNavItem)

@Pytal Pytal added the 3. to review Waiting for reviews label Nov 10, 2023
@Pytal Pytal added this to the Nextcloud 28 milestone Nov 10, 2023
@Pytal
Pytal requested review from artonge and juliusknorr November 10, 2023 19:19
@Pytal Pytal self-assigned this Nov 10, 2023
@juliusknorr

Copy link
Copy Markdown
Member

/backport to stable27

@juliusknorr

Copy link
Copy Markdown
Member

/backport to stable26

@backportbot-nextcloud backportbot-nextcloud Bot added the backport-request Pending backport by the backport-bot label Nov 10, 2023
@juliusknorr

Copy link
Copy Markdown
Member

/backport to stable25

@Pytal

Pytal commented Nov 10, 2023

Copy link
Copy Markdown
Member Author

/backport to stable24

@Pytal

This comment was marked as outdated.

@Pytal
Pytal force-pushed the enh/app-nav-data-id branch 2 times, most recently from fa48fe0 to cdb9513 Compare November 15, 2023 17:36
@Pytal

This comment was marked as outdated.

@Pytal

Pytal commented Nov 15, 2023

Copy link
Copy Markdown
Member Author

/compile amend /

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 15, 2023
@Pytal
Pytal merged commit 44ec2b5 into master Nov 15, 2023
@Pytal
Pytal deleted the enh/app-nav-data-id branch November 15, 2023 18:01
@Pytal Pytal removed the backport-request Pending backport by the backport-bot label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants