Conversation
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
juliusknorr
and removed request for
a team
May 27, 2022 15:40
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
blizzz
approved these changes
May 30, 2022
come-nc
approved these changes
Jun 7, 2022
|
|
||
| if ($result === 0 && isset($output[0])) { | ||
| $this->paths[$binary] = (string)$output[0]; | ||
| } else if (is_executable("/usr/bin/$binary")) { |
Contributor
There was a problem hiding this comment.
Suggested change
| } else if (is_executable("/usr/bin/$binary")) { | |
| } elseif (is_executable("/usr/bin/$binary")) { |
Not blocking but should still be fixed upstream
Merged
Member
|
/rebase |
Member
|
rebased for CI, the SMB tests should at least pass |
nextcloud-command
force-pushed
the
smb-353
branch
from
August 15, 2022 09:42
52fe991 to
a409372
Compare
Member
Author
|
I believe the sso tests are failing due to an issue with the user_saml setup, I'll need to take some time to debug that |
Merged
Merged
Member
|
/rebase |
nextcloud-command
force-pushed
the
smb-353
branch
from
December 16, 2022 17:18
a409372 to
12b4769
Compare
Merged
Merged
Merged
juliusknorr
removed their request for review
March 24, 2023 11:10
Contributor
|
/rebase |
szaimen
enabled auto-merge
April 17, 2023 14:51
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
nextcloud-command
force-pushed
the
smb-353
branch
from
April 17, 2023 16:06
12b4769 to
30b7147
Compare
Contributor
|
CI failure unrelated |
Contributor
|
/backport to stable26 |
Contributor
|
/backport to stable25 |
|
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin/stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25 |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.