refactor lib/private/OCS#39173
Merged
Merged
Conversation
fsamapoor
reviewed
Sep 29, 2023
fsamapoor
force-pushed
the
refactor_lib_private_ocs
branch
from
September 29, 2023 07:59
2d7d5aa to
99169fc
Compare
ChristophWurst
approved these changes
Oct 2, 2023
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Please squash into one commit
Merged
shdehnavi
force-pushed
the
refactor_lib_private_ocs
branch
2 times, most recently
from
December 11, 2023 12:54
88a5356 to
5e043f9
Compare
Contributor
Author
|
@ChristophWurst All commits squashed into one commit and all conflicts have been resolved. |
shdehnavi
force-pushed
the
refactor_lib_private_ocs
branch
from
December 11, 2023 13:17
7bfd837 to
37ecaa7
Compare
Member
|
shdehnavi
force-pushed
the
refactor_lib_private_ocs
branch
from
December 12, 2023 11:34
44e2c39 to
ade77a5
Compare
Contributor
Author
|
@ChristophWurst Psalm errors have been addressed in the last commit. |
ChristophWurst
approved these changes
Dec 12, 2023
fsamapoor
approved these changes
Dec 12, 2023
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com> Refactor lib/private/ocs Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com> Refactor lib/private/ocs Co-authored-by: Faraz Samapoor <f.samapoor@gmail.com> Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com> Add adjustments based on the review Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com> replace qualifier with an import Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com> refactor lib/private/OCS Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
skjnldsv
force-pushed
the
refactor_lib_private_ocs
branch
from
February 23, 2024 14:54
ade77a5 to
09b3702
Compare
skjnldsv
enabled auto-merge
February 23, 2024 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The required adjustments have been made to the classes in
/lib/private/OCSnamespace.The improvements:
Checklist