fix(federation): re-add RequestSharedSecret job if necessary#44848
Draft
blizzz wants to merge 1 commit into
Draft
fix(federation): re-add RequestSharedSecret job if necessary#44848blizzz wants to merge 1 commit into
blizzz wants to merge 1 commit into
Conversation
blizzz
requested review from
a team,
ArtificialOwl,
nfebe,
nickvergessen and
yemkareems
and removed request for
a team
April 16, 2024 11:18
nfebe
approved these changes
Apr 16, 2024
nfebe
left a comment
Contributor
There was a problem hiding this comment.
Tested and it works, code looks good.
blizzz
force-pushed
the
fix/noid/federation-really-surely-init-token
branch
from
July 25, 2024 15:18
6ca4917 to
7ce2309
Compare
Merged
fighting another race condition with federated server setup Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
AndyScherzinger
force-pushed
the
fix/noid/federation-really-surely-init-token
branch
from
September 3, 2024 10:21
7ce2309 to
1ba5841
Compare
nickvergessen
approved these changes
Sep 10, 2024
Member
|
Failing tests are related @blizzz |
Member
Author
|
backlog 😔 |
skjnldsv
marked this pull request as draft
November 15, 2024 13:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fighting another race condition with federated server setup
Summary
@fenn-cs and I saw another race condition when trying to set up trusted servers. Even when running cron-jobs hand-pickedly, we could end up in state where the
requestSharedSecretendpoint is called, claims to We will initiate the exchange of the shared secret, but does not have the appropriate Job in its list anymore.The change queries the joblist to see whether this one is actually scheduled, and adds it back if it is not the case.
Checklist