fix(files): Add missing emptyView handling#46917
Merged
Merged
Conversation
susnux
requested review from
a team,
Pytal and
nfebe
and removed request for
a team
July 31, 2024 13:46
skjnldsv
approved these changes
Jul 31, 2024
skjnldsv
left a comment
Member
There was a problem hiding this comment.
I did not even remembered I added the emptyView specifications 🤯
Pytal
approved these changes
Jul 31, 2024
Member
|
/compile rebase-amend /dist |
skjnldsv
enabled auto-merge
July 31, 2024 20:01
The interface provides this option but it was never implemented. This feature of being able to render a custom empty view message is needed for public file drops to properly show the terms of service. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/add-missing-empty-content
branch
from
July 31, 2024 20:08
379f79f to
f570507
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The interface for "Views" provides this option but it was never implemented.
One use case for this feature: Being able to render a custom empty view message for public file drops to properly show the terms of service.
Checklist