feat(api): File conversion Files action#50123
Merged
Merged
Conversation
8 tasks
skjnldsv
force-pushed
the
feat/file-conversion-provider-front
branch
from
January 10, 2025 11:11
48fb7eb to
6d94040
Compare
skjnldsv
changed the base branch from
feat/file-conversion-provider
to
master
January 10, 2025 11:11
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
2 tasks
This was referenced Jan 10, 2025
skjnldsv
force-pushed
the
feat/file-conversion-provider-front
branch
3 times, most recently
from
January 22, 2025 08:19
39d45ce to
a9f9549
Compare
Member
Author
|
Should be good to go! |
skjnldsv
force-pushed
the
feat/file-conversion-provider-front
branch
from
January 22, 2025 08:33
a9f9549 to
d6b8ccb
Compare
provokateurin
left a comment
Member
There was a problem hiding this comment.
Only some minor comments :)
skjnldsv
force-pushed
the
feat/file-conversion-provider-front
branch
2 times, most recently
from
January 22, 2025 08:52
994f43c to
14d97d7
Compare
artonge
reviewed
Jan 22, 2025
skjnldsv
force-pushed
the
feat/file-conversion-provider-front
branch
from
January 22, 2025 09:44
ea1f90c to
a028fe6
Compare
artonge
approved these changes
Jan 22, 2025
provokateurin
approved these changes
Jan 22, 2025
Member
Author
|
/compile rebase |
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
feat/file-conversion-provider-front
branch
from
January 22, 2025 16:31
54bf0fb to
eb92120
Compare
susnux
approved these changes
Jan 22, 2025
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Peek.22-01-2025.09-22.mp4
How-to
Save asand select the desired formatExplanations
Q. Why are we not using the default loading indicator
A. Conversion is kind of a background process, we wanna let the user keep using files while they happen in the background. That includes do other actions, which are disabled if we use the default loading indicator (marking the entire node as loading). The loader notification is permanent and will only remove itself on completion (error or success)
Followups