Skip to content

refactor: Cleanup files app bootstrap#59831

Merged
artonge merged 2 commits into
masterfrom
work/carl/files-applications-cleanup
Jul 1, 2026
Merged

refactor: Cleanup files app bootstrap#59831
artonge merged 2 commits into
masterfrom
work/carl/files-applications-cleanup

Conversation

@CarlSchwan

@CarlSchwan CarlSchwan commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Register event listener in the register method
  • Don't use a hook for injecting max_chunk_size in app config
  • Remove getUserFolder deprecated API usage

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@CarlSchwan CarlSchwan added this to the Nextcloud 34 milestone Apr 22, 2026
@CarlSchwan CarlSchwan self-assigned this Apr 22, 2026
@CarlSchwan
CarlSchwan requested a review from a team as a code owner April 22, 2026 10:06
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Apr 22, 2026
@CarlSchwan
CarlSchwan requested review from Altahrim and ArtificialOwl and removed request for a team April 22, 2026 10:06
@CarlSchwan CarlSchwan added the technical debt 🧱 🤔🚀 label Apr 22, 2026
@provokateurin

provokateurin commented Apr 22, 2026

Copy link
Copy Markdown
Member

I have tried some of this before, but it was failing for reasons I didn't understand back then: #50875

@CarlSchwan
CarlSchwan force-pushed the work/carl/files-applications-cleanup branch 2 times, most recently from fe5d86c to de9bb96 Compare April 22, 2026 12:03
@CarlSchwan

CarlSchwan commented Apr 22, 2026

Copy link
Copy Markdown
Member Author

I have tried some of this before, but it was failing for reasons I didn't understand back then: #50875

I think the problematic part was in apps/files_sharing/lib/Listener/LoadAdditionalListener.php fixed now

@CarlSchwan
CarlSchwan force-pushed the work/carl/files-applications-cleanup branch from de9bb96 to 209276c Compare April 22, 2026 13:52
@DorraJaouad
DorraJaouad requested a review from a team as a code owner April 23, 2026 09:41
@CarlSchwan
CarlSchwan force-pushed the work/carl/files-applications-cleanup branch from 209276c to 5893d6c Compare April 24, 2026 08:11
nickvergessen
nickvergessen reviewed Apr 24, 2026
View reviewed changes
Comment thread apps/files/lib/App.php
@CarlSchwan
CarlSchwan enabled auto-merge April 24, 2026 12:14
@CarlSchwan
CarlSchwan force-pushed the work/carl/files-applications-cleanup branch from 5893d6c to a77cc56 Compare May 5, 2026 12:44
@nextcloud-bot nextcloud-bot mentioned this pull request May 27, 2026
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Jun 4, 2026
Closed
@skjnldsv skjnldsv mentioned this pull request Jun 4, 2026
Merged
This was referenced Jun 5, 2026
Merged
Merged
@susnux susnux modified the milestones: Nextcloud 34.0.1, Nextcloud 35 Jun 9, 2026
@CarlSchwan
refactor: Cleanup files app bootstrap
0aafc14 
- Register event listener in the register method
- Remove hook for injecting max_chunk_size in app config and move
  that code directly in JSConfigHelper
- Remove getUserFolder deprecated API usage

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
CarlSchwan force-pushed the work/carl/files-applications-cleanup branch from a77cc56 to 125fb28 Compare June 23, 2026 12:19
susnux
susnux requested changes Jun 23, 2026
View reviewed changes
Comment thread apps/files/lib/AppInfo/Application.php Outdated
@CarlSchwan
CarlSchwan force-pushed the work/carl/files-applications-cleanup branch from 125fb28 to ddb2756 Compare June 23, 2026 13:42
@CarlSchwan
CarlSchwan requested a review from susnux June 23, 2026 13:44
susnux
susnux reviewed Jun 23, 2026
View reviewed changes
Comment thread apps/files/lib/AppInfo/Application.php Outdated
@CarlSchwan
refactor: Port away from OC_Util::tearDownFS
5de4784 
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
CarlSchwan force-pushed the work/carl/files-applications-cleanup branch from ddb2756 to 5de4784 Compare June 30, 2026 12:07
@CarlSchwan CarlSchwan added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 30, 2026
@artonge
artonge disabled auto-merge July 1, 2026 16:39
@artonge
artonge merged commit 9294ddf into master Jul 1, 2026
219 of 235 checks passed
@artonge
artonge deleted the work/carl/files-applications-cleanup branch July 1, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen left review comments
@susnux susnux susnux requested changes
@skjnldsv skjnldsv skjnldsv approved these changes
@DerDreschner DerDreschner DerDreschner approved these changes
@come-nc come-nc come-nc approved these changes
@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend
@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend
@provokateurin provokateurin Awaiting requested review from provokateurin

Assignees

@CarlSchwan CarlSchwan

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt 🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

9 participants

@CarlSchwan @provokateurin @nickvergessen @susnux @skjnldsv @DerDreschner @come-nc @artonge @nextcloud-bot