fix(s3): improve error on move/copy operations when bucket quota exceeded#59939
Closed
mejo- wants to merge 1 commit into
Closed
fix(s3): improve error on move/copy operations when bucket quota exceeded#59939mejo- wants to merge 1 commit into
mejo- wants to merge 1 commit into
Conversation
mejo-
requested review from
artonge,
leftybournes and
nfebe
and removed request for
a team
April 27, 2026 16:04
mejo-
commented
Apr 27, 2026
mejo-
force-pushed
the
fix/s3_quota_exceeded_error_message
branch
from
April 27, 2026 16:23
238192d to
957e811
Compare
mejo-
force-pushed
the
fix/files_move_or_copy_no_axios
branch
from
April 27, 2026 16:34
12b05e8 to
9020324
Compare
mejo-
force-pushed
the
fix/s3_quota_exceeded_error_message
branch
from
April 27, 2026 17:47
957e811 to
8a12a79
Compare
szaimen
requested review from
cuppett and
joshtrichards
and removed request for
szaimen
April 30, 2026 12:37
cuppett
reviewed
Apr 30, 2026
cuppett
left a comment
Contributor
There was a problem hiding this comment.
Recommend a more generic/re-usable UI error message.
Think we can defer finding additional, specific full/quota/limit errors and accumulate those over time given how many S3 providers could be used here (Ceph, Wasabi, QNAP QuObjects, etc.)
| if (error.response?.status === 412) { | ||
| throw new HintException(t('files', 'A file or folder with that name already exists in this folder')) | ||
| } else if (error.response?.status === 413) { | ||
| throw new HintException(t('files', 'Insufficient storage, quota exceeded')) |
Contributor
There was a problem hiding this comment.
I would recommend the error here being "file too large" versus quota specifically. The conditions we're adding here are for bucket quota, but also bubbling "EntityTooLarge" which could happen under multiple, future conditions. This message is a lot more re-usable just indicating a size issue in general.
Merged
Closed
Improves error messages on move/copy operations when bucket quota exceeded Fixes: #58801 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/s3_quota_exceeded_error_message
branch
from
July 15, 2026 11:06
8a12a79 to
bff9b94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #58801
Screenshots
Checklist
3. to review, feature component)stable32)AI (if applicable)