feat(core): reveal unified search filters from the input#62359
Open
pringelmann wants to merge 1 commit into
Open
feat(core): reveal unified search filters from the input#62359pringelmann wants to merge 1 commit into
pringelmann wants to merge 1 commit into
Conversation
pringelmann
commented
Jul 21, 2026
| @@ -33,12 +33,12 @@ | |||
| :wide="true" | |||
| @click="itemSelected(element)"> | |||
| <template #icon> | |||
| <NcAvatar v-if="element.isUser" :user="element.user" hide-user-status /> | |||
Contributor
Author
There was a problem hiding this comment.
Fixed incorrect prop name
pringelmann
commented
Jul 21, 2026
| * their internals. A custom input also lets us own the combobox semantics the | ||
| * results popover needs. On narrow viewports it collapses to an NcHeaderButton | ||
| * to match the other header items. | ||
| * A plain <input> rather than NcTextField/NcInputField: those assume a light form |
Contributor
Author
There was a problem hiding this comment.
Asked Claude to sweep over some of my previous comments to make them more concise
pringelmann
commented
Jul 21, 2026
| width: 16px; | ||
| height: 16px; | ||
| background-color: currentColor; | ||
| mask-image: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24'%3E%3Cpath d='M7.41 8.59 12 13.17l4.59-4.58L18 10l-6 6-6-6z'/%3E%3C/svg%3E"); |
Contributor
Author
There was a problem hiding this comment.
NcActions only exposes one icon slot. Perhaps we should add a second for this type of use case? ([category] label [chevron])
pringelmann
commented
Jul 21, 2026
| this.stopBackgroundWork() | ||
| } | ||
|
|
||
| reset(): void { |
Contributor
Author
There was a problem hiding this comment.
Unfortunately the easiest way to remove stale data. As mentioned in PR description: automatic teardown on unmount would be simpler, but out of scope here.
pringelmann
force-pushed
the
feat/search-filters
branch
from
July 21, 2026 09:02
44322b1 to
dfef6c5
Compare
pringelmann
marked this pull request as ready for review
July 21, 2026 09:02
pringelmann
requested review from
artonge,
kra-mo,
kristian-zendato,
nfebe,
sorbaugh and
susnux
and removed request for
a team
July 21, 2026 09:02
pringelmann
force-pushed
the
feat/search-filters
branch
from
July 21, 2026 09:40
dfef6c5 to
f9244e3
Compare
Contributor
Author
|
/compile rebase amend |
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
force-pushed
the
feat/search-filters
branch
from
July 21, 2026 10:20
f9244e3 to
d97ba14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a filter entry point to the header search and tightens its focus behavior.
Kooha-2026-07-21-10-35-48.webm
Other fixes made along the way:
reset()on the search controller clears stale state and ignores late responses. Slightly outside this PR's scope, folded in to avoid a separate PR. Ideally this should be refactored to a clean mount-based approach which tears down the modal on close, but that is a big change and out of scope for this redesign.Checklist
3. to review, feature component)stable32)AI (if applicable)