fix(ViewerComponent): use MarkdownContentEditor for readonly views#6268
Merged
Conversation
juliusknorr
approved these changes
Aug 27, 2024
Member
|
cypress failure seems related: |
mejo-
force-pushed
the
fix/viewer_attachments_read_only
branch
from
August 27, 2024 14:14
a853705 to
e8372b3
Compare
Also pass the `fileId` to the component. This adds support for displaying images and attachments in the read-only view. Fixes: #6267 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/viewer_attachments_read_only
branch
from
August 27, 2024 14:48
e8372b3 to
58c458e
Compare
Member
Author
Indeed, fixed now. |
Member
Author
|
/backport to stable30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also pass the
fileIdto the component. This adds support for displaying images and attachments in the read-only view.Fixes: #6267
I tested this PR with
The editor CSS includes (
prosemirror.cssandprint.css) were missing inMarkdownContentEditor, which resulted in broken view in Talk - probably because that was the only scenario where no second editor was loaded that the same time.🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)