module: runtime deprecate require.extensions#58642
Conversation
|
Review requested:
|
|
We should run citgm on this. |
| Type: Documentation-only | ||
| Type: Runtime | ||
|
|
||
| The [`require.extensions`][] property is deprecated. |
There was a problem hiding this comment.
I think an alternative, like module.register or module.registerHooks, should be recommended, and be stable, before runtime deprecating this.
There was a problem hiding this comment.
registerHooks, not register. The latter should go away once the former is ready. And registerHooks is a more appropriate replacement for extensions as both are sync.
There was a problem hiding this comment.
it would actually need an api that returns all the registered hooks + registerHooks
mcollina
left a comment
There was a problem hiding this comment.
I don't think we can do this before registerHooks() is stable.
|
This pull request has been marked as stale due to 210 days of inactivity. |
I'm opening this as draft PR to discuss if we should do runtime deprecate require.extensions.
It has been deprecated since v0.10.6.
This might have a large impact.
It's causing some issues for type stripping nodejs/typescript#37