test: add test for coverage control comments#59418
Conversation
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59418 +/- ##
==========================================
- Coverage 89.91% 89.87% -0.05%
==========================================
Files 655 656 +1
Lines 192828 192962 +134
Branches 37805 37846 +41
==========================================
+ Hits 173385 173419 +34
- Misses 12029 12100 +71
- Partials 7414 7443 +29 🚀 New features to boost your workflow:
|
|
Please follow commit message guideline #3 and wrap all lines at 72 columns (except for long URLs) in the first commit message, then update the commit. |
79cbd31 to
d05e777
Compare
This commit adds a TC to verify the node:coverage control comments.
remove identation
d05e777 to
6fdcdc0
Compare
I read the comment and changed the commit message! |
|
@mete0rfish Thanks for the contribution! |
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/17046636060 |
|
This pull request has been marked as stale due to 210 days of inactivity. |
This PR adds a comprehensive test suite for the
node:coverage control comments featurewithin the test runner.I noticed there wasn't a specific test that checked all coverage control comments (ignore next, disable/enable).
Also I have a couple of questions to ensure I'm following the project's guidelines:
control-commentsto describe the /* node:coverage */ comments. Is this the appropriate convention?coverage-control-comments.js. I want to ensure that adding the new fixture is right choice.I appreciate your feedback😀
refs: https://nodejs.org/api/test.html#collecting-code-coverage