[FIX] test_industry_real_estate: fix x_rental_contract_id test#1287
Closed
frva-odoo wants to merge 1 commit into
Closed
[FIX] test_industry_real_estate: fix x_rental_contract_id test#1287frva-odoo wants to merge 1 commit into
frva-odoo wants to merge 1 commit into
Conversation
Before this commit, the test failed because of one sale order demo data because its end_date was "30-10-{current_year}", making the related account_analytic_account missing a valid x_rental_contract_id by computation.
Instead of changing it, we complete the test taking into account the account_analytic_account that are not currently linked like this one to any sale order.
The test execute like before if there is one, otherwise we check that the sale order is either finished or to be started in the future.
Collaborator
|
|
vava-odoo
approved these changes
Oct 30, 2025
robodoo
pushed a commit
that referenced
this pull request
Oct 30, 2025
Before this commit, the test failed because of one sale order demo data because its end_date was "30-10-{current_year}", making the related account_analytic_account missing a valid x_rental_contract_id by computation.
Instead of changing it, we complete the test taking into account the account_analytic_account that are not currently linked like this one to any sale order.
The test execute like before if there is one, otherwise we check that the sale order is either finished or to be started in the future.
closes #1287
Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
This was referenced Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, the test failed because of one sale order demo data because its end_date was "30-10-{current_year}", making the related account_analytic_account missing a valid x_rental_contract_id by computation. Instead of changing it, we complete the test taking into account the account_analytic_account that are not currently linked like this one to any sale order. The test execute like before if there is one, otherwise we check that the sale order is either finished or to be started in the future.