Skip to content

[FIX] Selection: Fix navigation through merges#6616

Closed
rrahir wants to merge 1 commit into
16.0from
16.0-fix-keyboard-nav-merge-rar
Closed

[FIX] Selection: Fix navigation through merges#6616
rrahir wants to merge 1 commit into
16.0from
16.0-fix-keyboard-nav-merge-rar

Conversation

@rrahir

@rrahir rrahir commented Jun 17, 2025

Copy link
Copy Markdown
Collaborator

How to reproduce:

  • Create a merge in C3:D4
  • click on C5
  • Press Arrow-Up (this will select C3:D4)
  • press Shift+ArrowDown several times

-> your selection gets stuck to C3:D5

This occurs because the method that extends the selection does not behave correctly when the anchor is set on a Merge, it assumes that the anchor is always a single cell.

Task: 4873718

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

How to reproduce:
- Create a merge in C3:D4
- click on C5
- Press Arrow-Up (this will select C3:D4)
- press Shift+ArrowDown several times

-> your selection gets stuck to C3:D5

This occurs because the method that extends the selection does not
behave correctly when the anchor is set on a Merge, it assumes that the
anchor is always a single cell.

Task: 4873718
@robodoo

robodoo commented Jun 17, 2025

Copy link
Copy Markdown
Collaborator

Pull request status dashboard

@pro-odoo pro-odoo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Jun 26, 2025
How to reproduce:
- Create a merge in C3:D4
- click on C5
- Press Arrow-Up (this will select C3:D4)
- press Shift+ArrowDown several times

-> your selection gets stuck to C3:D5

This occurs because the method that extends the selection does not
behave correctly when the anchor is set on a Merge, it assumes that the
anchor is always a single cell.

closes #6616

Task: 4873718
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
@robodoo robodoo closed this Jun 26, 2025
@fw-bot fw-bot deleted the 16.0-fix-keyboard-nav-merge-rar branch July 3, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants