Skip to content

[statistics bottom bar] clicking on the open statistics menu does not close it#8969

Closed
matho-odoo wants to merge 1 commit into
masterfrom
master-close-statistic-onclick-matho
Closed

[statistics bottom bar] clicking on the open statistics menu does not close it#8969
matho-odoo wants to merge 1 commit into
masterfrom
master-close-statistic-onclick-matho

Conversation

@matho-odoo

@matho-odoo matho-odoo commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Description:

description of this task, what is implemented and why it is implemented that way.

Task: 6316288

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@matho-odoo matho-odoo force-pushed the master-close-statistic-onclick-matho branch 3 times, most recently from 3a783c0 to 956d5ec Compare June 19, 2026 13:01
@matho-odoo
[IMP] statistic bottom bar : close the menu
f012760 
Before this commit:
when we click on the statistics menu; it opens a popover.
This popover can be closed by pressing escape but not if we click a second time on the button

After this commit:
The popover can be closed by clicking on the button

Task: 6316288
@matho-odoo matho-odoo force-pushed the master-close-statistic-onclick-matho branch from 956d5ec to f012760 Compare June 19, 2026 13:15
@robodoo

robodoo commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Pull request status dashboard

@hokolomopo

hokolomopo commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Jun 25, 2026
@matho-odoo
[IMP] statistic bottom bar : close the menu
4520b61 
Before this commit:
when we click on the statistics menu; it opens a popover.
This popover can be closed by pressing escape but not if we click a second time on the button

After this commit:
The popover can be closed by clicking on the button

closes #8969

Task: 6316288
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
@robodoo robodoo added the 19.4 label Jun 25, 2026
@robodoo robodoo closed this Jun 25, 2026
@fw-bot fw-bot deleted the master-close-statistic-onclick-matho branch July 2, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

19.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matho-odoo @robodoo @hokolomopo