[FIX] mail: close change layout dialog when the call ends#273288
Closed
zel-odoo wants to merge 1 commit into
Closed
[FIX] mail: close change layout dialog when the call ends#273288zel-odoo wants to merge 1 commit into
zel-odoo wants to merge 1 commit into
Conversation
Opening "Change Layout" during a call adds a dialog via the dialog service. When the call was removed by the server (e.g. the `discuss.channel.rtc.session/ended` notification tears down the call and runs `endCall()`), the dialog stayed open. Clicking any option then ran `onSelectLayout`, which operates on the now-gone call (`channel.setAsDiscussThread()`, `rtc.enterFullscreen()`), and crashed. The action's `isSelfInCall` condition only gates opening a new dialog, never dismisses one already up. Close the dialog reactively when the user is no longer in the call, using Owl's reactive effect on `channel.isSelfInCall`, the same way `MessageReactionMenu` closes itself once its message loses all reactions. task-6352477
Contributor
|
|
alexkuhn
approved these changes
Jul 1, 2026
Contributor
robodoo
pushed a commit
that referenced
this pull request
Jul 2, 2026
Opening "Change Layout" during a call adds a dialog via the dialog service. When the call was removed by the server (e.g. the `discuss.channel.rtc.session/ended` notification tears down the call and runs `endCall()`), the dialog stayed open. Clicking any option then ran `onSelectLayout`, which operates on the now-gone call (`channel.setAsDiscussThread()`, `rtc.enterFullscreen()`), and crashed. The action's `isSelfInCall` condition only gates opening a new dialog, never dismisses one already up. Close the dialog reactively when the user is no longer in the call, using Owl's reactive effect on `channel.isSelfInCall`, the same way `MessageReactionMenu` closes itself once its message loses all reactions. task-6352477 closes #273288 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening "Change Layout" during a call adds a dialog via the dialog service. When the call was removed by the server (e.g. the
discuss.channel.rtc.session/endednotification tears down the call and runsendCall()), the dialog stayed open. Clicking any option then ranonSelectLayout, which operates on the now-gone call (channel.setAsDiscussThread(),rtc.enterFullscreen()), and crashed.The action's
isSelfInCallcondition only gates opening a new dialog, never dismisses one already up.Close the dialog reactively when the user is no longer in the call, using Owl's reactive effect on
channel.isSelfInCall, the same wayMessageReactionMenucloses itself once its message loses all reactions.task-6352477
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr