[FIX] orm: patch shared fields on module uninstall#273654
Closed
HydrionBurst wants to merge 1 commit into
Closed
Conversation
Overridden and inherited fields are shared across registries. Their `_args__` is cleared to save memory once they are no longer used as `_base_field__` of other fields (odoo#267486). During module uninstall we still need to disable prefetch on those fields. Building a new field with the shared instance as `_base_field__` fails without `_args__`. Duplicate the field with `copy.copy` and set `prefetch=False` on the copy instead.
Contributor
|
|
kmagusiak
approved these changes
Jul 2, 2026
Contributor
|
@HydrionBurst @rco-odoo 'ci/l10n' failed on this reviewed PR. |
robodoo
pushed a commit
that referenced
this pull request
Jul 2, 2026
Overridden and inherited fields are shared across registries. Their `_args__` is cleared to save memory once they are no longer used as `_base_field__` of other fields (#267486). During module uninstall we still need to disable prefetch on those fields. Building a new field with the shared instance as `_base_field__` fails without `_args__`. Duplicate the field with `copy.copy` and set `prefetch=False` on the copy instead. closes #273654 Signed-off-by: Raphael Collet <rco@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overridden and inherited fields are shared across registries. Their
_args__is cleared to save memory once they are no longer used as_base_field__of other fields (#267486).During module uninstall we still need to disable prefetch on those fields. Building a new field with the shared instance as
_base_field__fails without_args__. Duplicate the field withcopy.copyand setprefetch=Falseon the copy instead.Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr