feat: make PR review comments easier to scan#776
Open
Patrick-Erichsen wants to merge 5 commits into
Open
Conversation
Add a plain-language system context section and evidence-backed Mermaid flowchart immediately after merge readiness. Preserve compatibility by reading legacy summary headings and extracting the first action from the new Before merge table, including escaped pipes.
Surface sufficient real-behavior proof and two concrete evidence items in the human review while retaining the full evidence list in collapsed agent details. This preserves the proof, tests, and check signals contributors commonly cite in clawtributors.
| const section = markdownSection(body, "Before merge"); | ||
| if (!section) return ""; | ||
| for (const line of section.split(/\r?\n/)) { | ||
| const task = line.match(/^- \[[ xX]\]\s+(?:\*\*[^*]+\*\*\s+-\s+)?(.+)$/); |
Comment on lines
+18635
to
+18637
| return value | ||
| .replace(/\r?\n|\r/g, "<br>") | ||
| .replace(/\|/g, "\\|") |
| }; | ||
| const addPrioritized = (text: string, fallback: PublicPriority, label: string) => { | ||
| for (const line of publicRiskBulletsFromText(text, fallback).split("\n")) { | ||
| const match = line.match(/^-\s+\[(P[0-2])\]\s+(.+)$/); |
Comment on lines
+257
to
+259
| value | ||
| .replace(/\r?\n|\r/g, "<br>") | ||
| .replace(/\|/g, "\\|") |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: feat: make PR review comments easier to scan This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What this changes, followed by one dynamicMerge readinessoutcomeMeasure | Result | What it meanstable with the explicit(N/6)scaleVerificationtableAgent review detailsVisual reference: openclaw/openclaw#112487
Validation
Focused renderer, proof, risk, and review-history tests pass.
pnpm run checkpassed static checks, formatting, all builds, lint, and changed-file coverage. Its full cross-platform suite completed with 2,524 passing, 9 skipped, and 13 unrelated local failures in macOS/Linux containment and platform-sensitive path/timing tests (capsetunavailable on macOS,/private/varnormalization, and tight target-validation deadlines). No failures were in the touched review rendering paths.