enable workflow_dispatch and attach debug APK for Android CI#339
enable workflow_dispatch and attach debug APK for Android CI#339asumbek wants to merge 307 commits into
Conversation
…nto upstream-master
This reverts commit 2bf03e7.
Allows limiting the cache size via LRU algorithm, so that the periodic cache wipe doesn't use too much CPU resources.
Server-side sorting works properly now as the actual final score is submitted.
Remove duplicated get call
Update Gradle, AGP, and dependencies to their latest versions
Improve auto cursor behavior
Fix storyboard
…me during break period when the Flashlight mod is active
Normalize all asynchronous methods in one
|
Is there a reason for running the workflow on every push? |
It's already there since I made the workflow to attach artifacts, perhaps I need to restrict on certain path? |
|
Apologies, I meant to ask about the artifact part. |
|
If you meant why is it need to be attach with APK artifact, see the issue I referenced. |
|
I understand why, but I don't understand why the APK artifact must be attached on every push or pull request. |
|
There's no reason to it, other than being faster way to build the APK and test it right in your phone whether. I can restrict it to only attach when pushing/making PR on specific path, or restrict it at all and only attach if it's triggered by |
I think that would suffice. There may be cases where a commit should not be tested publicly (i.e., incomplete implementation of a feature), so it should be opt-in. |
|
Then disabling it via commit message could work, such as |
|
Closes #335
Changes to Android CI (
android.yml):workflow_dispatch