Skip to content

enable workflow_dispatch and attach debug APK for Android CI#339

Open
asumbek wants to merge 307 commits into
osudroid:masterfrom
asumbek:master
Open

enable workflow_dispatch and attach debug APK for Android CI#339
asumbek wants to merge 307 commits into
osudroid:masterfrom
asumbek:master

Conversation

@asumbek

@asumbek asumbek commented Mar 17, 2024

Copy link
Copy Markdown

Closes #335

Changes to Android CI (android.yml):

  • Enable workflow_dispatch
  • Attach debug APK and SHA256 checksum file

Rian8337 and others added 30 commits October 3, 2023 10:05
Allows limiting the cache size via LRU algorithm, so that the periodic cache wipe doesn't use too much CPU resources.
Server-side sorting works properly now as the actual final score is submitted.
@Rian8337

Copy link
Copy Markdown
Member

Is there a reason for running the workflow on every push?

@asumbek

asumbek commented Mar 18, 2024

Copy link
Copy Markdown
Author

Is there a reason for running the workflow on every push?

It's already there since I made the workflow to attach artifacts, perhaps I need to restrict on certain path?

@Rian8337

Copy link
Copy Markdown
Member

Apologies, I meant to ask about the artifact part.

@asumbek

asumbek commented Mar 19, 2024

Copy link
Copy Markdown
Author

If you meant why is it need to be attach with APK artifact, see the issue I referenced.

@Rian8337

Copy link
Copy Markdown
Member

I understand why, but I don't understand why the APK artifact must be attached on every push or pull request.

@asumbek

asumbek commented Mar 24, 2024

Copy link
Copy Markdown
Author

There's no reason to it, other than being faster way to build the APK and test it right in your phone whether. I can restrict it to only attach when pushing/making PR on specific path, or restrict it at all and only attach if it's triggered by workflow_dispatch event.

@Rian8337

Copy link
Copy Markdown
Member

or restrict it at all and only attach if it's triggered by workflow_dispatch event.

I think that would suffice. There may be cases where a commit should not be tested publicly (i.e., incomplete implementation of a feature), so it should be opt-in.

@asumbek

asumbek commented Mar 28, 2024

Copy link
Copy Markdown
Author

Then disabling it via commit message could work, such as noci or skipci at the end of commit message.

@Rian8337

Copy link
Copy Markdown
Member

so it should be opt-in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make android.yml workflow to output APK artifacts

5 participants