Skip to content

[FEATURE REQUEST] Improvements in "Manage accounts" view #4148

Closed

Description

@jesmrec

EPIC:

This is the current look of the Manage accounts:

Screenshot 2023-08-31 at 09 17 03

TASKS

  • Research (if needed)
  • Create branch feature/improvements_in_manage_accounts_view
  • Development tasks
    • Avoid overlapping between the username and the icons
    • Remove key icon
    • Make lost-credentials Snackbar equal for every auth (with the Sign in option in basic auth too)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/improvements_manage_accounts into master

Activity

  1. jesmrec commented on Sep 4, 2023

    @jesmrec
    MemberAuthor

    About the key icon: removing is not a problem whether the account is token-based (OAuth2, OIDC) because the Sign-in snackbar is there to regain authentication.

    But, if the account is basic auth and password changes in server, there is no way to get Sign-in snackbar because there are no available sessions (basic auth works with an authenticated header). Key icon is required to re-enter a new one.

    So, i'd keep it for basic auth accounts and remove for token accounts (if feasible).

    CC @michaelstingl

  2. michaelstingl commented on Sep 4, 2023

    @michaelstingl
    Contributor

    But, if the account is basic auth and password changes in server, there is no way to get Sign-in snackbar because there are no available sessions (basic auth works with an authenticated header). Key icon is required to re-enter a new one.

    So, i'd keep it for basic auth accounts and remove for token accounts (if feasible).

    CC @michaelstingl

    When passwords change on the server, clients receive 401's too. This should trigger re-login.

  3. jesmrec commented on Sep 4, 2023

    @jesmrec
    MemberAuthor

    there is no 401 because server creates a new session (new cookie) that supports it without losing auth. Making this work with basic auth will trigger probably deeper and tricky changes (needs research to accurate). This is the issue:

    Screenshot 2023-09-04 at 13 00 47
  4. jesmrec commented on Sep 4, 2023

    @jesmrec
    MemberAuthor

    Well, kept testing it and after some time, 401 is returned, but the snackbar is different:

    Screenshot 2023-09-04 at 13 09 37

    no way to regain auth, only to select another account.

  5. jesmrec commented on Sep 19, 2023

    @jesmrec
    MemberAuthor

    iOS approach in account management:

    List of accounts Options of every account No access Regain access
    screenshot-1695120524711 screenshot-1695120678576 screenshot-1695121067183 screenshot-1695121079115

    Some inputs to move Android approach to the iOS one:

    • Android app will remove sync option and make it automatic somehow (new issue)
    • Change account in basic auth may need redefinition to be similar to browser auth. Then, it could be removed from account manager
    • Manage in iOS removes all downloaded files from the account. New feature in Android with two options: manual and auto. Check how to integrate in the accounts manager view
    • Android app lacks of a "log out" option. [QA] no logout from identity provider possible #3872. Out of scope of this issue, imho

    more ideas?

  6. jesmrec commented on Oct 18, 2023

    @jesmrec
    MemberAuthor

    In order to remove the key icon and make behaviour consistent between browser/no browser authentication:

    • Cookies to be removed every time the app is killed. It'll force the app to ask for a new one once it's open again. In case password changed, 401 will be returned

    • If basic authentication is lost (password changed, user disabled), show snackbar with same message of browser auth instead of the current

    • Redirection message in snackbar must prompt to login view instead of manage accounts view.

    Achieving these, we'll be in position to remove the key icon.

  7. changed the title [-]Changes in "Manage Accounts" view[/-] [+][FEATURE REQUEST] Changes in "Manage Accounts" view[/+] on Feb 12, 2024
  8. changed the title [-][FEATURE REQUEST] Changes in "Manage Accounts" view[/-] [+][FEATURE REQUEST] Improvements in "Manage Accounts" view[/+] on Feb 12, 2024
  9. changed the title [-][FEATURE REQUEST] Improvements in "Manage Accounts" view[/-] [+][FEATURE REQUEST] Improvements in "Manage accounts" view[/+] on Feb 13, 2024
  10. self-assigned this
    on Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions