You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[FEATURE REQUEST] Improvements in "Manage accounts" view #4148
Key icon could be removed (after research on Cookie handling #4227). In case credentials are lost, Snackbar with Sign In option is in the file list. May need to check if removing the key icon could carry other side-effects
About the key icon: removing is not a problem whether the account is token-based (OAuth2, OIDC) because the Sign-in snackbar is there to regain authentication.
But, if the account is basic auth and password changes in server, there is no way to get Sign-in snackbar because there are no available sessions (basic auth works with an authenticated header). Key icon is required to re-enter a new one.
So, i'd keep it for basic auth accounts and remove for token accounts (if feasible).
But, if the account is basic auth and password changes in server, there is no way to get Sign-in snackbar because there are no available sessions (basic auth works with an authenticated header). Key icon is required to re-enter a new one.
So, i'd keep it for basic auth accounts and remove for token accounts (if feasible).
there is no 401 because server creates a new session (new cookie) that supports it without losing auth. Making this work with basic auth will trigger probably deeper and tricky changes (needs research to accurate). This is the issue:
Some inputs to move Android approach to the iOS one:
Android app will remove sync option and make it automatic somehow (new issue)
Change account in basic auth may need redefinition to be similar to browser auth. Then, it could be removed from account manager
Manage in iOS removes all downloaded files from the account. New feature in Android with two options: manual and auto. Check how to integrate in the accounts manager view
In order to remove the key icon and make behaviour consistent between browser/no browser authentication:
Cookies to be removed every time the app is killed. It'll force the app to ask for a new one once it's open again. In case password changed, 401 will be returned
If basic authentication is lost (password changed, user disabled), show snackbar with same message of browser auth instead of the current
Redirection message in snackbar must prompt to login view instead of manage accounts view.
Achieving these, we'll be in position to remove the key icon.
changed the title [-][FEATURE REQUEST] Changes in "Manage Accounts" view[/-][+][FEATURE REQUEST] Improvements in "Manage Accounts" view[/+]on Feb 12, 2024
changed the title [-][FEATURE REQUEST] Improvements in "Manage Accounts" view[/-][+][FEATURE REQUEST] Improvements in "Manage accounts" view[/+]on Feb 13, 2024
Activity
jesmrec commentedon Sep 4, 2023
About the key icon: removing is not a problem whether the account is token-based (OAuth2, OIDC) because the
Sign-insnackbar is there to regain authentication.But, if the account is basic auth and password changes in server, there is no way to get
Sign-insnackbar because there are no available sessions (basic auth works with an authenticated header). Key icon is required to re-enter a new one.So, i'd keep it for basic auth accounts and remove for token accounts (if feasible).
CC @michaelstingl
michaelstingl commentedon Sep 4, 2023
When passwords change on the server, clients receive
401's too. This should trigger re-login.jesmrec commentedon Sep 4, 2023
there is no
401because server creates a new session (new cookie) that supports it without losing auth. Making this work with basic auth will trigger probably deeper and tricky changes (needs research to accurate). This is the issue:jesmrec commentedon Sep 4, 2023
Well, kept testing it and after some time,
401is returned, but the snackbar is different:no way to regain auth, only to select another account.
jesmrec commentedon Sep 19, 2023
iOS approach in account management:
Some inputs to move Android approach to the iOS one:
Change accountin basic auth may need redefinition to be similar to browser auth. Then, it could be removed from account managerManagein iOS removes all downloaded files from the account. New feature in Android with two options: manual and auto. Check how to integrate in the accounts manager viewmore ideas?
jesmrec commentedon Oct 18, 2023
In order to remove the key icon and make behaviour consistent between browser/no browser authentication:
Cookies to be removed every time the app is killed. It'll force the app to ask for a new one once it's open again. In case password changed, 401 will be returned
If basic authentication is lost (password changed, user disabled), show snackbar with same message of browser auth instead of the current
Redirection message in snackbar must prompt to login view instead of manage accounts view.
Achieving these, we'll be in position to remove the key icon.
[-]Changes in "Manage Accounts" view[/-][+][FEATURE REQUEST] Changes in "Manage Accounts" view[/+][-][FEATURE REQUEST] Changes in "Manage Accounts" view[/-][+][FEATURE REQUEST] Improvements in "Manage Accounts" view[/+][-][FEATURE REQUEST] Improvements in "Manage Accounts" view[/-][+][FEATURE REQUEST] Improvements in "Manage accounts" view[/+]