Skip to content

[FEATURE REQUEST] Improve the removed from original folder option in Auto Uploads #4357

Closed

Description

@jesmrec

The option removed from original folder in auto uploads is potentially destructive

Screenshot 2024-04-04 at 13 40 53

Removing the local file when worker moves the taken pictures to the scoped storage forces the uploads to work in order not to lose the pictures/videos. If upload fails for X reason and is not recoverable, the file is lost: it is neither in server, nor in local

Some solutions:

  • Adding a warning when option is clicked: The pictures/videos taken by the camera will not be available in your device anymore. This could be potentially dangerous in case of failure in the uploads because external reasons. In that way, problem is not solved but user is warned about the existing perils.

  • Removing the local file only when the upload is finished. Not sure how to control this, unless different kinds of uploads are distinguishable.

  • Other ideas...

TASKS

  • Research (if needed)
  • Create branch feature/feature_name
  • Development tasks
    • Create Work to remove local file
    • Enqueued two works: uploadFileFromContentUriWorker and removeLocalFileWorker.
    • Removed code relate to remove local file in UploadFileFromContentUriWorker
    • Implement unit tests (if needed)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master

Activity

  1. JuancaG05 commented on Apr 5, 2024

    @JuancaG05
    Contributor

    Could be that auto-uploads are removed instantly because permissions are removed by Android over the files after a while... Needs to be checked

  2. added this to the 4.4 - Future milestone on Apr 5, 2024
  3. self-assigned this
    on Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions