Skip to content

[BUG] "Clear data" button malfunctioning - #4343

Closed
Aitorbp wants to merge 6 commits into
masterfrom
fix/clear_data_button_malfunctioning
Closed

Aitorbp wants to merge 6 commits into
masterfrom
fix/clear_data_button_malfunctioning

Conversation

@Aitorbp

@Aitorbp Aitorbp commented Mar 19, 2024 •

Copy link
Copy Markdown
Contributor

Related Issues

App:#4309

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@Aitorbp Aitorbp self-assigned this Mar 19, 2024
@Aitorbp Aitorbp linked an issue Mar 19, 2024 that may be closed by this pull request
@Aitorbp
Aitorbp requested a review from JuancaG05 March 19, 2024 13:52
@Aitorbp
Aitorbp force-pushed the fix/clear_data_button_malfunctioning branch from 52cb0a4 to 1fabf58 Compare March 25, 2024 15:51

@JuancaG05 JuancaG05 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot approve this. This is deleting the data of the app (including shared preferences) but not the logged in accounts. It results in removing the security lock methods when you press the "Clear data" button but keep the access to the accounts. We'll need to discuss how to address this issue in an alternative way.

@Aitorbp Aitorbp closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] "Clear data" button malfunctioning

2 participants