Skip to content

Version author gets overwritten with wrong uid #39672

Closed

Description

@JammingBen

Steps to reproduce

  1. Set file_storage.save_version_author to true
  2. Create a file "test.txt" as admin user
  3. Share the file with "user01"
  4. As "user01", edit this file -> The current author is "user01", the author of the first version is "admin" -> all good!
  5. As "user01", roll back the first version -> current author is "admin" (good!), however, the author of the first version is now "admin" as well (bad!)

Expected behaviour

The version author should be "user01"

Activity

  1. JammingBen commented on Jan 11, 2022

    @JammingBen
    ContributorAuthor

    Another error which goes in a similar direction:

    • Set file_storage.save_version_author to false
    • Create a file "test.txt" as admin user
    • As "admin", create a new version of this file
    • As "admin", share the file with "user01"
    • Set file_storage.save_version_author to true
    • As "user01", create a new version of this file
    • As "user01", restore a previous version -> The current version will be moved to the version list, including "user01" as author -> good!
    • As "user01", roll back the version with "user01" as author again -> the current version (that has no author) will be moved to the version list -> "user01" is displayed as author for this version -> bad!
  2. added a commit that references this issue on Jan 11, 2022
  3. JammingBen commented on Jan 11, 2022

    @JammingBen
    ContributorAuthor

    Fixed via #39673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions