Skip to content

Put defaultMailHeaderColor back - #31701

Merged
phil-davis merged 1 commit into
masterfrom
put-defaultMailHeaderColor-back
Jun 8, 2018
Merged

phil-davis merged 1 commit into
masterfrom
put-defaultMailHeaderColor-back

Conversation

@VicDeo

@VicDeo VicDeo commented Jun 8, 2018

Copy link
Copy Markdown
Contributor

this line was unintentionally removed in #31683

@VicDeo VicDeo added this to the development milestone Jun 8, 2018
@VicDeo VicDeo self-assigned this Jun 8, 2018
@VicDeo
VicDeo requested a review from PVince81 June 8, 2018 14:37

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 sadly no unit test caught this ?

@VicDeo

VicDeo commented Jun 8, 2018 •

Copy link
Copy Markdown
Contributor Author

@PVince81 AFAIK It's a matter of style. PHP emits a notice (depending on php.ini) and consider missing property to be public.

@codecov

codecov Bot commented Jun 8, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #31701 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #31701   +/-   ##
=========================================
  Coverage     62.91%   62.91%           
  Complexity    18424    18424           
=========================================
  Files          1156     1156           
  Lines         69184    69184           
  Branches       1260     1260           
=========================================
  Hits          43527    43527           
  Misses        25288    25288           
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 52.39% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.12% <ø> (ø) 18424 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/defaults.php 46.46% <ø> (ø) 40 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b08fce1...8a8c9b0. Read the comment docs.

@phil-davis
phil-davis merged commit a3bf212 into master Jun 8, 2018
@phil-davis
phil-davis deleted the put-defaultMailHeaderColor-back branch June 8, 2018 15:29
@phil-davis

Copy link
Copy Markdown
Contributor

Needs to be in with the other PR backport, I guess.

@VicDeo

VicDeo commented Jun 8, 2018

Copy link
Copy Markdown
Contributor Author

Already in #31699

@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock

lock Bot commented Jul 31, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants