Skip to content

[full-ci] Show Legal statement by personal settings - #40511

Merged
DeepDiver1975 merged 8 commits into
owncloud:masterfrom
T0mWz:LegalStatement
Feb 6, 2023
Merged

DeepDiver1975 merged 8 commits into
owncloud:masterfrom
T0mWz:LegalStatement

Conversation

@T0mWz

@T0mWz T0mWz commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

Description

When your own legal statements are published, handy to show them at your personal settings page.

How Has This Been Tested?

  • Applied within own environment

Screenshots (if appropriate):

Screenshot 2022-11-23 at 10 51 48

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

ToDo:

  • Translation option added

@CLAassistant

CLAassistant commented Nov 23, 2022 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@mmattel

mmattel commented Jan 30, 2023

Copy link
Copy Markdown
Contributor

@T0mWz you need to sign the CLA to proceed, see the link above, it is just a click...

@mmattel

mmattel commented Jan 30, 2023

Copy link
Copy Markdown
Contributor

@phil-davis can you re-trigger CI ?

@T0mWz

T0mWz commented Jan 30, 2023

Copy link
Copy Markdown
Contributor Author

ow, I already did that. But do it directly again @mmattel !

@mmattel

mmattel commented Jan 30, 2023

Copy link
Copy Markdown
Contributor

I already did that

hmmm, I just clicked on recheck but it is still the same...?
Can you pls redo signing the online CLA?

@phil-davis

Copy link
Copy Markdown
Contributor

I rebased and force-pushed. Up-to-date CI is running.

The commit is by https://github.com/tomwezepoel @tomwezepoel and not by @T0mWz

So "signing the CLA needs to be done by @tomwezepoel

Tom - I suppose that both accounts are you, the same person? What happened?

@phil-davis phil-davis self-assigned this Jan 31, 2023
@T0mWz

T0mWz commented Jan 31, 2023

Copy link
Copy Markdown
Contributor Author

I rebased and force-pushed. Up-to-date CI is running.

The commit is by https://github.com/tomwezepoel @tomwezepoel and not by @T0mWz

So "signing the CLA needs to be done by @tomwezepoel

Tom - I suppose that both accounts are you, the same person? What happened?

Ahja, shared personality. Haha!

@mmattel

mmattel commented Jan 31, 2023

Copy link
Copy Markdown
Contributor

A changelog entry is needed.

@mmattel mmattel changed the title Show Legal statement by personal settings [full-ci] Show Legal statement by personal settings Jan 31, 2023
@mmattel

mmattel commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

@phil-davis @DeepDiver1975 approve?

@mmattel

mmattel commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

@T0mWz you need to run a php style fix. To do so, run 'make help' in the repo root and near the bottom of the output you will see the command example, then repush.

@owncloud owncloud deleted a comment from update-docs Bot Feb 3, 2023
@phil-davis

Copy link
Copy Markdown
Contributor

A changelog entry is needed.

done

@phil-davis

Copy link
Copy Markdown
Contributor

@T0mWz you need to run a php style fix. To do so, run 'make help' in the repo root and near the bottom of the output you will see the command example, then repush.

done

@phil-davis

Copy link
Copy Markdown
Contributor

Note: this makes use of the existing core settings legal.privacy_policy_url and legal.imprint_url that have existed for some time - e.g. see old PR https://github.com/owncloud/theme-enterprise/pull/25 and #31699

@sonarqubecloud

sonarqubecloud Bot commented Feb 3, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

72.8% 72.8% Coverage
1.7% 1.7% Duplication

@phil-davis

Copy link
Copy Markdown
Contributor

@DeepDiver1975 or @jvillafanez please also review. IMO this is ready to merge.

@DeepDiver1975
DeepDiver1975 merged commit 7ea9862 into owncloud:master Feb 6, 2023
phil-davis added a commit that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants