Repository navigation
Set checksum if not seeked - #40513
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
💥 Acceptance tests pipeline apiProxySmoke-8-2-mariadb10.2-php7.4 failed. The build has been cancelled. https://drone.owncloud.com/owncloud/core/37334/168 |
|
@phil-davis is it possible to add some acceptance tests for this scenario? Basically, if the download has a request range, no checksum should be generated. If there is a checksum already, it won't be changed. |
|
Merging. We have only the one expected fsweb error in the ci, that is unrelated to this. |
Description
Range downloads might set up a wrong checksum if there isn't a checksum set. This causes problems later because a full download will send the wrong checksum and clients might flag the download even though the file was downloaded ok.
Note that range downloads might still get the checksum of the whole file, not just the downloaded piece.
In addition, appending content won't calculate a checksum.
There are some additional cases that might still need to be covered
Related Issue
https://github.com/owncloud/enterprise/issues/5457
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Notes