Skip to content

fix: use correct l10n folder when theme is enabled and apps_path is a… - #40607

Merged
DeepDiver1975 merged 1 commit into
masterfrom
fix/assert-themed-l10n-folder-to-be-folders
Feb 6, 2023
Merged

DeepDiver1975 merged 1 commit into
masterfrom
fix/assert-themed-l10n-folder-to-be-folders

Conversation

@DeepDiver1975

@DeepDiver1975 DeepDiver1975 commented Jan 30, 2023 •

Copy link
Copy Markdown
Contributor

… symlink

Description

Due to magic path operations an instance could explode under following constellation:

  • theme enabled
  • symlinked oc installation like /var/www/owncloud -> /var/www/owncloud-10.12.13-crazy.long-name

Motivation and Context

How Has This Been Tested?

  • ✋
  • unit test will follow

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs

update-docs Bot commented Jan 30, 2023

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975
DeepDiver1975 force-pushed the fix/assert-themed-l10n-folder-to-be-folders branch 2 times, most recently from ccd4dbc to 1808a64 Compare January 30, 2023 13:14

@IljaN IljaN left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very knowledgeable around this parts of core, but LGMT 👍

@phil-davis

Copy link
Copy Markdown
Contributor

@DeepDiver1975 changelog?

@DeepDiver1975

Copy link
Copy Markdown
Contributor Author

I also have one test case pending. Will finish tomorrow

@DeepDiver1975
DeepDiver1975 force-pushed the fix/assert-themed-l10n-folder-to-be-folders branch from 1808a64 to 1141ca2 Compare February 2, 2023 07:30
@DeepDiver1975
DeepDiver1975 force-pushed the fix/assert-themed-l10n-folder-to-be-folders branch from 1141ca2 to 8f928dc Compare February 6, 2023 13:59
@ownclouders

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline apiShareReshareToRoot2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/37858/64

@sonarqubecloud

sonarqubecloud Bot commented Feb 6, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@DeepDiver1975
DeepDiver1975 merged commit 6118a8d into master Feb 6, 2023
@delete-merged-branch
delete-merged-branch Bot deleted the fix/assert-themed-l10n-folder-to-be-folders branch February 6, 2023 15:43
@jnweiger

jnweiger commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants