Repository navigation
Fix quota for 32 bits. Some vars could be float instead of integer - #40727
Closed
jvillafanez wants to merge 2 commits into
Closed
jvillafanez wants to merge 2 commits into
jvillafanez wants to merge 2 commits into
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
SonarCloud Quality Gate failed. |
Member
Author
|
Closing in favor of #40729 , which targets the release branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
The type of some variables seems to be different than the ones we expect based on some conditions.
In particular, 32 bits systems seem to use floats instead of integers in some of our "getSize" methods, which was causing problems because we expected only integers. Quota calculation was affected by this.
The problem with the quota is fixed with this PR also for 32 bits systems because we've taken into consideration that the size could be either an integer or a float.
Most of the "getSize" methods have been adjusted so the PHPDoc shows the right information. The behavior of the methods hasn't been touched (no new issues should happen)
Related Issue
#40709
Motivation and Context
How Has This Been Tested?
Not tested with 32 bits but with 64 bits. I don't see any problem
Test1
Test2
Test3
Test4
Screenshots (if appropriate):
Types of changes
Checklist: