Repository navigation
fix: update ca-bundle.crt - #41908
Conversation
Signed-off-by: Shaan Majid <70789625+shaanmajid@users.noreply.github.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
@shaanmajid thanks for the contribution. Please click the button to "sign" the CLA. |
|
@phil-davis Done! |
There was a problem hiding this comment.
Thanks for this. The bundle is byte-identical to curl's cacert-2026-10-20.pem (sha256 796f1389… checks out), so the certificate content is fine. A few things about how the change is described, and one process item:
1. The changelog and PR understate the change. This isn't a one-root removal: the bundle goes from 146 to 118 roots, with 35 removed and 7 added. Removed:
35 removed roots
- AffirmTrust Commercial / Networking / Premium / Premium ECC
- Atos TrustedRoot 2011
- Certigna
- certSIGN ROOT CA
- CommScope Public Trust ECC Root-01 / ECC Root-02 / RSA Root-01 / RSA Root-02
- COMODO Certification Authority
- DigiCert Assured ID Root CA
- DigiCert Global Root CA
- DigiCert High Assurance EV Root CA
- emSign ECC Root CA - C3
- emSign ECC Root CA - G3
- emSign Root CA - C1
- Entrust Root Certification Authority / - EC1 / - G2
- ePKI Root Certification Authority
- FIRMAPROFESIONAL CA ROOT-A WEB
- GLOBALTRUST 2020
- GTS Root R2
- QuoVadis Root CA 2 / Root CA 3
- Secure Global CA
- SecureSign Root CA12
- SecureTrust CA
- SwissSign Gold CA - G2
- TeliaSonera Root CA v1
- Trustwave Global Certification Authority / ECC P256 / ECC P384
Added: e-Szigno TLS Root CA 2023, OISTE Server Root ECC G1 / RSA G1, SECOM TLS ECC / RSA Root CA 2024, Telia EC / RSA TLS Root CA v3.
Several of these (DigiCert Global Root CA, the Entrust roots, COMODO, QuoVadis) still anchor chains in the wild, especially for on-prem endpoints. After upgrading, outgoing HTTPS from the server (federation, external storage, OIDC discovery, marketplace) to such an endpoint fails with unable to get local issuer certificate. That is a behaviour change admins need to hear about, so please make the entry a Change: rather than a Bugfix:, state that 35 roots were removed in line with Mozilla's store (naming the widely used ones), and point to the workaround: occ security:certificates:import <file> to trust a removed root again. The "non-breaking" box in the PR description should be updated to match.
2. The emSign wording is incomplete. emSign Root CA - C1 and emSign ECC Root CA - C3 are also removed, while emSign Root CA - G1 is still trusted. The changelog only mentions G3, which leaves both groups of eMudhra customers guessing. A sentence covering all four would settle it.
3. One of the verification steps proves nothing. "AAA Certificate Services" isn't in the current bundle on master either, so its absence after the update says nothing about this change. The G3 check is the meaningful one.
Separately, I'll open two PRs for problems in CertificateManager that this update depends on but that aren't caused by it. Installed instances read a cached rootcerts.crt that is rebuilt only based on file mtimes, so a new ca-bundle.crt isn't guaranteed to take effect. Neither PR needs to block this one.
Signed-off-by: Shaan Majid <70789625+shaanmajid@users.noreply.github.com>
|
Updated to address review |
fix: update ca-bundle.crt (#41908) * feat: update ca-bundle.crt * chore: add changelog for CA bundle update * chore: describe the root removals in the changelog --------- (cherry picked from commit 1065a71) Signed-off-by: Shaan Majid <70789625+shaanmajid@users.noreply.github.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com> Co-authored-by: Shaan Majid <70789625+shaanmajid@users.noreply.github.com>
Description
Replace
resources/config/ca-bundle.crtwith curl's 2026-10-20 extract of the Mozilla root store (https://curl.se/ca/cacert-2026-10-20.pem), byte-identical, as in #41411.The bundle goes from 146 to 118 roots: 35 removed in line with Mozilla, 7 added. The removals include roots that still anchor some chains, such as DigiCert Global Root CA, the Entrust roots, COMODO Certification Authority and QuoVadis Root CA 2 and 3. Outgoing HTTPS to a server that chains only to one of them fails verification after the update. The changelog item names these and the workaround,
occ security:certificates:import.Related Issue
None.
Motivation and Context
Eight eMudhra intermediate CA keys were compromised (disclosure). They chain to emSign ECC Root CA - G3, which the current bundle trusts. The HTTP client uses this bundle by default, so outgoing HTTPS accepts certificates issued with those keys. Mozilla removed the root.
How Has This Been Tested?
796f1389…).openssl pkcs7 -print_certs).Types of changes
Checklist: