Skip to content
This repository was archived by the owner on Aug 21, 2026. It is now read-only.

Document the public-files WebDAV API endpoint - #1879

Merged
settermjd merged 6 commits into
masterfrom
document-public-files-webdav-api
Oct 10, 2019
Merged

settermjd merged 6 commits into
masterfrom
document-public-files-webdav-api

Conversation

@settermjd

Copy link
Copy Markdown
Contributor

This relates to owncloud/core/pull/35932 and #1871.

@settermjd settermjd added work in progress Still in development. Not to be merged. developer docs APIs labels Oct 2, 2019
@settermjd settermjd self-assigned this Oct 2, 2019
@settermjd
settermjd force-pushed the document-public-files-webdav-api branch from e3501dc to 0660804 Compare October 4, 2019 03:56
@settermjd

Copy link
Copy Markdown
Contributor Author

@DeepDiver1975, can you review, pls?

@settermjd settermjd added review required waiting on feedback and removed work in progress Still in development. Not to be merged. labels Oct 4, 2019
@settermjd settermjd changed the title [WIP] Document the public-files WebDAV API endpoint Document the public-files WebDAV API endpoint Oct 4, 2019
@settermjd

Copy link
Copy Markdown
Contributor Author

ping, @DeepDiver1975.

@DeepDiver1975 DeepDiver1975 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • request with password is missing - basic auth header with public:${share-password}

@settermjd

Copy link
Copy Markdown
Contributor Author
* request with password is missing - basic auth header with public:${share-password}

Thanks for calling that out. Will fix it.

@settermjd

Copy link
Copy Markdown
Contributor Author
* request with password is missing - basic auth header with public:${share-password}

Which example are you referring to? Both the curl and PHP request examples submit auth headers.

These are added as per @deepdiver's comments
https://github.com/owncloud/docs/pull/1879/files#r332913897. An
admonition's been added to document how to access the public links when
they are password protected.
@settermjd

Copy link
Copy Markdown
Contributor Author

@DeepDiver1975, both points of feedback have been addressed.

…d/docs into document-public-files-webdav-api
@settermjd
settermjd force-pushed the document-public-files-webdav-api branch from 1f16497 to 1664cae Compare October 9, 2019 10:49
@settermjd

Copy link
Copy Markdown
Contributor Author

Latest changes implemented.

@settermjd
settermjd merged commit b050106 into master Oct 10, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the document-public-files-webdav-api branch October 10, 2019 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants