Repository navigation
Closed
Description
For example:
https://drone.owncloud.com/owncloud/encryption/1887/149/11 2021-05-21am
Feature: transfer-ownership
@smokeTest @skipOnEncryptionType:user-keys
Scenario: transferring ownership of a file # /var/www/owncloud/testrunner/tests/acceptance/features/cliMain/transfer-ownership.feature:6
Given user "Alice" has been created with default attributes and small skeleton files # FeatureContext::userHasBeenCreatedWithDefaultAttributes()
And user "Brian" has been created with default attributes and small skeleton files # FeatureContext::userHasBeenCreatedWithDefaultAttributes()
And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/somefile.txt" # FeatureContext::userHasUploadedAFileTo()
When the administrator transfers ownership from "Alice" to "Brian" using the occ command # TransferOwnershipContext::theAdministratorTransfersOwnershipFromToUsingTheOccCommand()
Then the command should have been successful # OccContext::theCommandShouldHaveBeenSuccessful()
And the downloaded content when downloading file "/somefile.txt" for user "Brian" with range "bytes=0-6" from the last received transfer folder should be "This is" # TransferOwnershipContext::downloadedContentWhenDownloadingForUserWithRangeShouldBe()
The downloaded content was expected to be 'This is', but actually is '<?xml v'. HTTP status was 500
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'This is'
+'<?xml v'
...
runsh: Total unexpected failed scenarios throughout the test run:
cliMain/transfer-ownership.feature:6
cliMain/transfer-ownership.feature:15
cliMain/transfer-ownership.feature:29
cliMain/transfer-ownership.feature:39
cliMain/transfer-ownership.feature:50
cliMain/transfer-ownership.feature:62
cliMain/transfer-ownership.feature:74
And the same each night:
https://drone.owncloud.com/owncloud/encryption/1890/149/11 2021-05-22
https://drone.owncloud.com/owncloud/encryption/1891/149/11 2021-05-23
https://drone.owncloud.com/owncloud/encryption/1892/149/11 2021-05-24
https://drone.owncloud.com/owncloud/encryption/1893/149/11 2021-05-25
The test pipeline uses mySQL 8.0
Metadata
Metadata
Assignees
Labels
No labels
Activity
phil-davis commentedon May 25, 2021
Note: also see owncloud/core#38770 - update-testing CI also started failing the same night. Maybe related? But they could be caused by different PRs that were merged to core on 2021-05-20.
phil-davis commentedon May 25, 2021
Note encryption PR #273 was merged on 2021-05-19 and the transfer-ownership tests passed in the nightly that ran on the morning of 2021-05-20. So I don't think that encryption PR is the problem.
phil-davis commentedon May 25, 2021
This is an example from owncloud.log:
https://drone.owncloud.com/owncloud/encryption/1893/149/8
phil-davis commentedon May 25, 2021
There is an owncloud.log traceback above.
@micbar which developer would be best to look into this?
micbar commentedon May 25, 2021
@karakayasemi Can you take a look?
IljaN commentedon May 25, 2021
I am also already looking in to this since it is blocking me. But a second pair of eyes won't hurt I guess.
IljaN commentedon May 25, 2021
In my local environment a different set of tests fails when running
~/c/c/a/encryption:λ make test-acceptance-cli(inside encryption app)Not sure if related to my env.
phil-davis commentedon May 25, 2021
@IljaN the tests expect that the encryption app is already enabled, and the desired encryption setting (master or user keys) has been selected.
IljaN commentedon May 25, 2021
Hmhh Tests seem to pass locally. Latest core master, trying previouse encryption versions, php7.4
Trying in 7.2 + mysql
IljaN commentedon May 26, 2021
I can reproduce this now.
IljaN commentedon May 26, 2021
Bisect first bad commit: owncloud/core@08f84d8
IljaN commentedon May 26, 2021
Tested by reverting => Tests pass 🟢
Environment: php7.2 + mariadb
FYI @jvillafanez
IljaN commentedon May 26, 2021
PR: owncloud/core#38649
jvillafanez commentedon May 26, 2021
Not sure if it will be helpful, but below it's a extract of the filecache before and after the transfer (encryption is disabled):
There is something wrong with the md5 calculation:
f24455ec205f27299f3ad1c9c51d67ffis a wrong md5, not sure where it comes from.jvillafanez commentedon May 26, 2021
Ok, I think I've figure it out. It's basically a doble replacement that happens with the new query. We're setting the path first, then, while updating the path_hash, the path is replaced again because it matches.
Inverting the order of the sets should fix the problem.
jvillafanez commentedon May 27, 2021
owncloud/core#38783 should fix the problem. I've tested the file transfer manually and I didn't notice anything weird with the patch. The md5 is the right one, and there is no duplicate in the filecache.
IljaN commentedon May 27, 2021
Confirmed: Transfer ownership tests pass now.
phil-davis commentedon May 27, 2021
owncloud/core#38783 has been merged.
ToDo:
IljaN commentedon May 27, 2021
Hmhhh still fails in PR: https://drone.owncloud.com/owncloud/encryption/1898/92/11
doublechecking...
phil-davis commentedon May 27, 2021
https://drone.owncloud.com/owncloud/encryption/1898/92/5
Fetched 10.8.0 prealpha - channel: daily - build at 2021-05-26T22:00:22+00:00 - SHA: 01fd0c378e608a59c9c2b39eff302afb202e96fd
The CI installs the current daily-master-qa tarball. That is updated every evening. We will know tomorrow morning, after the tarball is updated with the new core master code.
IljaN commentedon May 27, 2021
Thanks! I assumed PR CI always pulls latest master.
phil-davis commentedon May 28, 2021
The transfer-ownership pipelines all passed in nightly CI: https://drone.owncloud.com/owncloud/encryption/1899
Note: I have some other test scenarios merged to core yesterday in PR owncloud/core#38764
That caused some fails here: https://drone.owncloud.com/owncloud/encryption/1899/212/17
That is a separate task to adjust the skipping, nothing to do with this transfer-ownership issue.