Add per-target zinc compile stats#4790
Merged
Merged
Conversation
baroquebobcat
approved these changes
Aug 9, 2017
benjyw
reviewed
Aug 9, 2017
| tgt, = vts.targets | ||
| fatal_warnings = self._compute_language_property(tgt, lambda x: x.fatal_warnings) | ||
| zinc_file_manager = self._compute_language_property(tgt, lambda x: x.zinc_file_manager) | ||
| start_time = time.time() |
Contributor
There was a problem hiding this comment.
Maybe use the Timer class from pants.util.contextutil?
benjyw
reviewed
Aug 9, 2017
benjyw
left a comment
Contributor
There was a problem hiding this comment.
Maybe use the Timer class from pants.util.contextutil?
baroquebobcat
approved these changes
Aug 9, 2017
baroquebobcat
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty good!
Just a couple comments, but I don't consider them blocking.
- Could you note specifically what info you are adding to the reporting in the summary?
- Also, I'd like to see tests for this if possible.
Member
|
I cannot wait to use this. Thanks stu! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Visibility into the size and compile time of individual JVM targets is currently not great. While log parsing is possible, it's not scalable for this usecase.
Solution
Now that we have an API for recording target information, begin recording zinc compilation info.
Result
The
target_dataentry in the posted JSON stats contains information like the following:... in addition to any data recorded by junit.