Log if artifact downloads are slow#5208
Merged
illicitonion merged 2 commits intoDec 15, 2017
Merged
Conversation
Right now, sometimes pants looks like it may be hanging or deadlocking if cache fetches are really slow. This adds an INFO level log if any particular artifact has spent 60 seconds waiting for 4MB of output from the cache on any particular thread. This corresponds with a download speed of less than 67K/s sustained over at at least 4MB of output artifact. It's possible that these messages will be displayed more often than once every 60 seconds, if multiple threads are seeing this slowness in parallel.
Contributor
|
Looks reasonable to me. How did you test it? |
Contributor
Author
|
I set the 60 seconds at 0.1 seconds and saw lots of output lines. I then set it to 1 second and saw a few. |
baroquebobcat
approved these changes
Dec 14, 2017
Contributor
Author
|
Yeah, I gave it some thought originally, but decided that any test would end up being very large and convoluted that it probably wouldn't be worth its value... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, sometimes pants looks like it may be hanging or deadlocking
if cache fetches are really slow.
This adds an INFO level log if any particular artifact has spent 60
seconds waiting for 4MB of output from the cache on any particular
thread.
This corresponds with a download speed of less than 67K/s sustained over
at at least 4MB of output artifact.
It's possible that these messages will be displayed more often than once
every 60 seconds, if multiple threads are seeing this slowness in
parallel.