Handle RPC errors as well as message-inline errors#6589
Merged
Conversation
This required a minor change to grpcio (pantsbuild/grpc-rs@4dfafe9) to not throw away the information from the grpc stack.
Doesn't work right now because servers can't fail with a Status
stuhood
approved these changes
Oct 4, 2018
| .into_future() | ||
| // If there was a response, drop the _stream to disconnect so that the server doesn't keep | ||
| // the connection alive and continue sending on it. | ||
| .map(|(maybe_operation, _stream)| maybe_operation) |
Member
There was a problem hiding this comment.
Worth explicitly dropping with mem::drop and placing the comment there? On the other hand, maybe doing it this way is less confusing for a new rust user because it doesn't make mem::drop seem magical.
| } | ||
| } | ||
|
|
||
| //#[test] // TODO: Unignore this test when the server can actually fail with status protos. |
Member
There was a problem hiding this comment.
Worth creating a ticket for this?
stuhood
added a commit
to twitter/pants
that referenced
this pull request
Oct 6, 2018
stuhood
pushed a commit
that referenced
this pull request
Oct 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This required a minor change to grpcio
(pantsbuild/grpc-rs@4dfafe9)
to not throw away the information from the grpc stack.