Add bounds checking to Entry::current_running_duration#6643
Merged
stuhood merged 2 commits intoOct 17, 2018
Conversation
… where a Node is started after we begin computing heavy_hitters.
illicitonion
approved these changes
Oct 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As shown in #6640, once we moved
Entrylocks outside of theGraphlock in #6095, it became possible forheavy_hittersto race againstNodesthat are starting outside of theGraphlock.Solution
Add a bounds check for
Instant::duration_sinceincurrent_running_duration, to handle the case where a Node is started after we begin computingheavy_hitters. While switching toInstant::elapsedwould "mostly" avoid this case, it would incur additional syscalls, without fully avoiding panics.Result
Fixes #6640.