Skip to content

feat(Compass): remove background props, update structure #12408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcoker merged 5 commits into from
May 12, 2026
Merged

feat(Compass): remove background props, update structure #12408

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c9657d5
feat(Compass): remove background props, update structure
kmcfaul May 4, 2026
102f970
move props to compass from container, update tests to remove bg
kmcfaul May 5, 2026
cc877d0
rebase, add panel props, update CompassMainHeader panel props name
kmcfaul May 11, 2026
c22da97
remove full height, add glass to other panels in demo
kmcfaul May 11, 2026
d3b4c19
bump core, update snap
kmcfaul May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove full height, add glass to other panels in demo
  • Loading branch information
@kmcfaul
kmcfaul committed May 12, 2026
commit c22da9764cf4910471460b7af7833edbdf1fa38c
10 changes: 5 additions & 5 deletions packages/react-core/src/demos/Compass/examples/CompassDemo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const CompassBasic: React.FunctionComponent = () => {

const navContent = (
<>
<Panel isPill>
<Panel isPill isGlass>
<PanelMain>
<PanelMainBody>
<CompassNavContent>
Expand Down Expand Up @@ -70,7 +70,7 @@ export const CompassBasic: React.FunctionComponent = () => {
</PanelMainBody>
</PanelMain>
</Panel>
<Panel isPill>
<Panel isPill isGlass>
<PanelMain>
<PanelMainBody style={{ padding: 0 }}>
<TabContent id="subtabs" ref={subTabsRef}>
Expand Down Expand Up @@ -105,7 +105,7 @@ export const CompassBasic: React.FunctionComponent = () => {
);

const sidebarContent = (
<Panel isPill>
<Panel isPill isGlass>
<PanelMain>
<PanelMainBody>
<ActionList isIconList isVertical>
Expand Down Expand Up @@ -155,7 +155,7 @@ export const CompassBasic: React.FunctionComponent = () => {
</CompassHero>
<CompassMainHeader title={<Title headingLevel="h1">Content title</Title>} panelProps={{ isGlass: true }} />
<CompassContent>
<Panel isScrollable isAutoHeight isFullHeight isGlass>
<Panel isScrollable isAutoHeight isGlass>
<PanelMain>
<PanelMainBody>Content</PanelMainBody>
</PanelMain>
Expand All @@ -166,7 +166,7 @@ export const CompassBasic: React.FunctionComponent = () => {
const sidebarEndContent = sidebarContent;
const footerContent = (
<CompassMessageBar>
<Panel isPill>
<Panel isPill isGlass>
<PanelMain>
<PanelMainBody style={{ padding: 0 }}>Message bar</PanelMainBody>
</PanelMain>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/demos/Compass/examples/CompassDockDemo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ export const CompassDockDemo: React.FunctionComponent = () => {
<>
<CompassMainHeader title={<Title headingLevel="h1">Content title</Title>} panelProps={{ isGlass: true }} />
<CompassContent>
<Panel isScrollable isAutoHeight isFullHeight isGlass>
<Panel isScrollable isAutoHeight isGlass>
<PanelMain>
<PanelMainBody>Content</PanelMainBody>
</PanelMain>
Expand Down