K8SPG-613: add unit-test #1204
Merged
K8SPG-613: add unit-test #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkech
reviewed
Jul 2, 2025
| }) | ||
| }) | ||
|
|
||
| crunchyCr := v1beta1.PostgresCluster{} |
There was a problem hiding this comment.
Why this is defined outside the It("should get PostgresCluster", func() {? From what I can see it is not used anywhere else.
| Expect(initContainer.Resources).To(Equal(corev1.ResourceRequirements{})) | ||
| Expect(initContainer.SecurityContext).To(Equal(&corev1.SecurityContext{ | ||
| Capabilities: &corev1.Capabilities{ | ||
| Drop: []corev1.Capability{ |
There was a problem hiding this comment.
Casting to corev1.Capability can be omitted.
| Expect(len(stsList.Items)).To(Equal(3)) | ||
| }) | ||
| It("should have updated init container", func() { | ||
| Expect(len(stsList.Items)).To(Equal(3)) |
There was a problem hiding this comment.
We repeat the same assertion 3 lines above, is this needed? I think we can remove this here.
There was a problem hiding this comment.
we do the same in some It's below
commit: ae5e927 |
gkech
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPG-613
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability