-
Notifications
You must be signed in to change notification settings - Fork 64
K8SPG-624 Add support for S3ForcePathStyle and verifyTLS for custom extensions #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
- name: STORAGE_BUCKET | ||
value: pg-extensions | ||
value: operator-testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's better to use separate bucket to store extensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmarukovich it is a temporary minio deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll approve after the shfmt
warning fix
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fixed, 1757812 |
CHANGE DESCRIPTION
Problem:
When installing external extensions, the storage configuration is missing the options for force path style and SSL enabling. We should introduce these options so that S3 compatible storages can be used for storing external extensions.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Sample CR:
Notice this
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability