Repository navigation
#include cleanup part 3 - #10279
Merged
Merged
#include cleanup part 3#10279
Conversation
Girgias
reviewed
Jan 10, 2023
MaxKellermann
force-pushed
the
include_cleanup3
branch
from
January 10, 2023 15:00
0f66f64 to
8339bb6
Compare
Contributor
Author
|
CI failures look similar:
I guess some sources need to include |
Without this, the macros ZTS, ZEND_DEBUG and PHP_COMPILER_ID may be unavailable.
MaxKellermann
force-pushed
the
include_cleanup3
branch
from
January 10, 2023 16:57
8339bb6 to
0132753
Compare
Contributor
Author
That's it, that include was missing in |
MaxKellermann
force-pushed
the
include_cleanup3
branch
from
January 10, 2023 17:11
0132753 to
e79e504
Compare
Contributor
Author
|
Yay, all green. @Girgias? |
Girgias
approved these changes
Jan 12, 2023
cmb69
added a commit
that referenced
this pull request
Jan 16, 2023
Cf. <#10220 (comment)>. This reverts commit 45a128c. This reverts commit 1eb71c3. This reverts commit 492523a. This reverts commit c7a4633. This reverts commit 308adb9. This reverts commit cd27d5e. This reverts commit c593340. This reverts commit 46371f4. This reverts commit 623e2e9. This reverts commit e7434c1. This reverts commit d28d323. This reverts commit 1a067b8. This reverts commit a55c0c5. This reverts commit b5aeb3a. This reverts commit f061a03. This reverts commit b088575. This reverts commit b1d4877. This reverts commit 94f9a20. This reverts commit 4831e48. This reverts commit cd985de. This reverts commit 9521d21. This reverts commit d613615.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #10216 and #10220
All commits ordered in a way that each of them builds properly, to avoid breaking bisects.
@Girgias?