Skip to content

osu!taiko simplify pp summing and make performance attributes accurate #33500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 8, 2025

Conversation

buyaspacecube
Copy link
Member

This change replaces the (diff^1.1 + acc^1.1)^1/1.1 formula applied to pp with simply diff+acc, adjusting multipliers for minimal value changes. Taiko's acc values being lower than difficulty on every single play bar a few exceptions means that all this formula did was make acc have even less of an effect on a play's total pp. This is another step towards the larger acc rebalance we have planned for next deploy. Multipliers have also been moved around so that the Difficulty and Accuracy performance attributes always add up to make Total. The approved but not yet merged change to remove multipliers to the Easy mod is also included, hope that doesn't cause trouble merging this

Copy link
Member

@Lawtrohux Lawtrohux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, happy with the changes. once we get everything in we can start balancing, however values look good with and without.

Copy link
Member

@stanriders stanriders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts

@stanriders stanriders moved this from Pending Review to Pending Maintainers Review in Difficulty calculation changes Jun 6, 2025
@buyaspacecube buyaspacecube requested a review from stanriders June 6, 2025 18:37
@stanriders stanriders enabled auto-merge (squash) June 8, 2025 08:43
@stanriders stanriders merged commit 6ae8a68 into ppy:pp-dev Jun 8, 2025
4 of 8 checks passed
@github-project-automation github-project-automation bot moved this from Pending Maintainers Review to Pending Deploy in Difficulty calculation changes Jun 8, 2025
@buyaspacecube buyaspacecube deleted the multiplier-cleanup branch June 8, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending Deploy
Development

Successfully merging this pull request may close these issues.

3 participants